Re: [PATCH v2 2/2] selftests/damon/sysfs.py: validate memcg_path staging readback

[Cheng Nie]

On Fri, 29 May 2026 08:00:56 -0700 SeongJae Park wrote:

> I'd prefer the error message to be in form of something like "'memcg_path
> staging: kdamond start (%s)' % err" for consistency.

Will do.

> It seems we don't really need to do commit().  As Sashiko mentioned [1], it
> also depends on CONFIG_MEMCG and active cgroup configuration.   It would be
> suffice to simply 'stage'.  We don't have stage() method on Kdamonds, though.
> What about setting all parameters including the memcg filter at the beginning,
> do 'kdamonds.start()', but ignore the failure, and check the content of the
> memcg_path file?

Agreed, thanks for the suggestion.  I will drop commit() and configure the
memcg filter up front, then verify memcg_path readback after staging via
start() as you suggested.

I will send a follow-up patch with these changes.

Thanks,
Cheng Nie