Re: [PATCH] gpu: nova-core: gsp: tu102: keep unloading if FWSEC-SB fails

[Eliot Courtney]

On Sun May 31, 2026 at 9:37 PM JST, Alexandre Courbot wrote:
> On Turing and Ampere, resetting the GSP involves running two firmware
> images: FWSEC-SB and Booter Unloader. They are independent from one
> another, and we should do whatever is possible to restore the GSP's
> unloaded state even if a failure occurs along the way.
>
> Thus, keep going and run Booter Unloader even if the execution of
> FWSEC-SB failed.
>
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Closes: https://sashiko.dev/#/patchset/20260529-nova-unload-v7-0-678f39209e00%40nvidia.com?part=3
> Fixes: adb99ce3cc78 ("gpu: nova-core: run Booter Unloader and FWSEC-SB upon unbinding")
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---

It seems that in openrm and nouveau AFAICT these two cleanups are both
done regardless if either fails.

Reviewed-by: Eliot Courtney <ecourtney@xxxxxxxxxx>

nit: it seems odd to me to log on fwsec-sb failure but not on booter
unloader failure.