Re: [PATCH 2/5] selftests/damon: fix memcg filter path handling

From: Kunwu Chan

Date: Sun May 31 2026 - 22:20:05 EST


June 1, 2026 at 12:36 AM, "SeongJae Park" <sj@xxxxxxxxxx mailto:sj@xxxxxxxxxx?to=%22SeongJae%20Park%22%20%3Csj%40kernel.org%3E > wrote:


>
> Conventionally, this mail should be sent as a direct reply to the coverletter.
> But somehow this was sent as a reply to the first patch of the series. Please
> send all patches of a series as a direct reply to the coverletter from the next
> time.
>
Thanks, SJ.

Sorry about that. I'll make sure future revisions are sent as direct
replies to the cover letter.

> On Sun, 31 May 2026 17:17:21 +0800 Kunwu Chan <kunwu.chan@xxxxxxxxx> wrote:
>
> >
> > From: Kunwu Chan <kunwu.chan@xxxxxxxxx>
> >
> > A trailing comma in the memcg_path assignment makes
> > memcg_path a single-element tuple instead of a string.
> >
> > As a result, an invalid value is written to sysfs and memcg
> > filter configuration fails.
> >
> > Remove the comma.
> >
> Good findinng! But, Cheng sent [1] a same patch earlier. I believe Cheng is
> working on revisioning it. I think we should give Cheng more time for that.
>
Yes, I noticed that after sending the series and saw that Cheng had
already posted the same fix.

I'll drop this patch from v2 and let Cheng continue with his version.

Thanks,
Kunwu

> [1] https://lore.kernel.org/20260529145248.84593-1-sj@xxxxxxxxxx
>
> Thanks,
> SJ
>
> [...]
>