Re: [PATCH v2 3/4] pinctrl: qcom: spmi-gpio: Rearchitect for flexible group support

[Fenglin Wu]

On 5/30/2026 6:31 PM, Krzysztof Kozlowski wrote:
> On Thu, May 28, 2026 at 06:05:37PM -0700, Fenglin Wu wrote:
> > Currently, the driver treats each pin as a group, and every pin or
> > group can function correctly in all existing functions. However,
> > this approach is no longer valid since some PMIC pins only operate
> > together in specific functions, which are limited to certain GPIO
> > groups. For example, in pmh0101, the level-shifter function is
> > supported only between GPIO pairs like GPIO11/12, GPIO13/14,
> > GPIO15/16, and GPIO17/18.
> >
> > To better accommodate these new functions and restrict GPIOs to
> > those that support them, rearchitect the driver to enable flexible
> > pinctrl group configurations by utilizing the generic pinctrl group
> > and function APIs.
> >
> > Signed-off-by: Fenglin Wu <fenglin.wu@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/pinctrl/qcom/Kconfig             |   2 +
> >   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 377 +++++++++++++++++++++----------
> And now make this built-in and RPMH as module, then build it. Does
> it build?
Thanks. I missed to add the dependency in patch4 which really adds the 
rpmh control. I will update the Kconfig to make it depends on rpmh and 
cmd-db drivers.
> Best regards,
> Krzysztof