Re: [PATCH v4 3/4] selftests/mm: use pkey_assert on clone_raw failure in pkey test
From: Hongfu Li
Date: Mon Jun 01 2026 - 01:32:42 EST
Hi,
> > Use pkey_assert(0) instead of perror("clone") when clone_raw() fails.
> > The old path only printed an error and continued; the test now exits
> > via pkey_assert() on failure so it does not hang or proceed with an
> > invalid child.
>
> Looks like clone() invocation changes in patch 2 belong here.
> But is there actually a need to change ret = clone_raw() to
> child_pid = clone_raw()?
You're right. This variable change seems pointless, and I'll revert
it in the next patch version.