Re: [PATCH 4/8] arm64: dts: qcom: shikra: Add CAMSS node
From: Nihal Kumar Gupta
Date: Mon Jun 01 2026 - 02:46:52 EST
On 29-05-2026 20:28, Bryan O'Donoghue wrote:
>> Regarding cdm iommu we have excluded it as we do not use it to program registers as of now.
>
> Which will be a problem as soon as CDM is attempted to be enabled and yaml changes are dropped upstream.
>
> Hmm then it seems to me that five is too many for Agatti's IOMMU set.
>
> I'd like a number list so that we are discussing facts instead of nebulous hypotheticals.
>
> For both Agatti and Shikra.
Here is the full IOMMU SID list for both platforms:
Agatti (QCM2290):
- 0x0400 0x00 — VFE non-protected
- 0x0800 0x00 — CDM non-protected
- 0x0820 0x00 — OPE read non-protected
- 0x0840 0x00 — OPE write non-protected
Shikra:
- 0x0400 0x00 — VFE non-protected
- 0x0600 0x00 — CDM non-protected
- 0x0620 0x00 — OPE read non-protected
- 0x0640 0x00 — OPE write non-protected
Only VFE SID (0x0400) is shared between the two platforms.
The current Shikra submission enumerates only the VFE SID.
Should CDM and OPE each get a separate YAML binding like [1], or
should both be part of the CAMSS YAML binding? If part of CAMSS,
please confirm and we will add their SIDs in the DTS in the next revision.
[1] https://lore.kernel.org/all/20260508-camss-isp-ope-v3-9-bb1055274603@xxxxxxxxxxxxxxxx/