Re: [net-next PATCH v10 2/9] net: dsa: realtek: rtl8365mb: reject unsupported topologies

[Linus Walleij]

On Sat, May 30, 2026 at 12:51 PM Luiz Angelo Daros de Luca
<luizluca@xxxxxxxxx> wrote:

> Explicitly enforce the presence of a CPU port (-EINVAL) and reject DSA
> cascade links (-EOPNOTSUPP) during setup to prevent silent failures.
>
> These topologies were already non-functional. Without a CPU port, the
> driver does not activate CPU tagging. Additionally, the switch hardware
> was not designed to be cascaded, and DSA links never worked because
> CPU tagging is not enabled for them.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij