Re: [PATCH v3 3/3] iio: flow: add Sensirion SLF3S liquid flow sensor driver

[Jonathan Cameron]

Just picking one thing to add to from the set of good points from Marcelo.

> ...
> > +static const struct iio_chan_spec_ext_info slf3s_ext_info[] = {
> > +	IIO_ENUM("medium", IIO_SHARED_BY_TYPE, &slf3s_medium_enum),
> > +	IIO_ENUM_AVAILABLE("medium", IIO_SHARED_BY_TYPE, &slf3s_medium_enum),  
> We should probably document the new 'medium' ABI.
> For consolidated ABI, we document it in Documentation/ABI/testing/sysfs-bus-iio.
> Since this is new stuf, maybe start with a separate ABI doc
> (e.g. Documentation/ABI/testing/sysfs-bus-iio-slf3s) ?

Definitely needs docs but maybe go one up sysfs-bus-iio-flow.
This is intended to be a generic ABI but one specific to flow sensors.


> 
> > +	{ }
> > +};  
> 
> With best regards,
> Marcelo