Re: [PATCH v4 02/13] liveupdate: avoid mixing cleanup guards with goto in luo_session_retrieve_fd

[Pratyush Yadav]

On Sat, May 30 2026, Pasha Tatashin wrote:

> Refactoring luo_session_retrieve_fd() to avoid mixing automated
> cleanup-style guards with goto-based resource release, which is not
> recommended under the Linux kernel coding style.
>
> Signed-off-by: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>

Perhaps we would be better off moving to FD_ADD() at some point, which
should make this a little bit simpler?

Anyway, this patch is still an improvement, so

Reviewed-by: Pratyush Yadav (Google) <pratyush@xxxxxxxxxx>

[...]

-- 
Regards,
Pratyush Yadav