Re: [PATCH v11 12/22] gpu: nova-core: Hopper/Blackwell: add FSP secure boot completion waiting

[Alexandre Courbot]

On Mon Jun 1, 2026 at 5:32 PM JST, Eliot Courtney wrote:
> On Mon Jun 1, 2026 at 4:48 PM JST, Alexandre Courbot wrote:
>> On Sat May 30, 2026 at 12:09 PM JST, John Hubbard wrote:
>>> +
>>> +impl Fsp {
>>> +    /// Wait for FSP secure boot completion.
>>> +    ///
>>> +    /// Polls the thermal scratch register until FSP signals boot completion
>>> +    /// or timeout occurs.
>>> +    pub(crate) fn wait_secure_boot(dev: &device::Device, bar: &Bar0, chipset: Chipset) -> Result {
>>
>> ... and with the design proposed above, this method can return
>> `Result<Fsp>`: we are not supposed to use `Fsp` it until secure boot has
>> successfully completed, so making it return the instance that enables
>> the other methods guarantees that this has happened at the API level.
>
> I think this is a good direction. I think we can also make FspFirmware
> owned by this fsp::Fsp object - i.e., move more control of FSP from
> Gh100::boot to the Fsp object. You might need to change up FmcBootArgs
> and e.g. return something from `boot_fmc` to keep the DMA allocation
> alive.

Good idea - that would also remove one parameter from `FmcBootArgs` later.