Re: [PATCH mm-hotfixes] mm/huge_memory: use correct flags for device private PMD entry
From: Lorenzo Stoakes
Date: Mon Jun 01 2026 - 12:02:44 EST
On Mon, Jun 01, 2026 at 09:20:51PM +0530, Dev Jain wrote:
> Sashiko continues to find existing problems :) What do you think:
>
> https://sashiko.dev/#/patchset/20260601083044.57132-1-ljs%40kernel.org
Thanks for highlighting Dev and to be clear I'm not yelling at you :P I'm
yelling about this aspect of sashiko... :)
So, this patch fixes a serious issue that renders THP device-private
completely broken in a way that can lead to memory corruption, and this
review comment has nothing to do with that :)
So TL;DR - maybe as a follow up?
IMO there's _no_ obligation to respond to stuff like this, in the same
way as somebody in a review saying 'hey here's this unrelated broken
thing'.
And this kind of thing should _never_ _ever_ block a series or patch.
(I kinda wish sashiko didn't do it, I have extremely limited time as it is,
it'd be better as a passive background scan of existing issues or
something.)
Cheers, Lorenzo