Re: [PATCH v11 04/22] gpu: nova-core: Hopper/Blackwell: larger non-WPR heap

[John Hubbard]

On 5/31/26 7:24 PM, Alexandre Courbot wrote:
> On Sat May 30, 2026 at 12:09 PM JST, John Hubbard wrote:
...>> @@ -37,6 +41,13 @@ pub(crate) trait FbHal {
>>  
>>      /// Returns the FRTS size, in bytes.
>>      fn frts_size(&self) -> u64;
>> +
>> +    /// Returns the non-WPR heap size for this chipset, in bytes.
>> +    ///
>> +    /// Older architectures use 1 MiB. Hopper and Blackwell override this.
>> +    fn non_wpr_heap_size(&self) -> u32 {
>> +        u32::SZ_1M
>> +    }
> 
> I'm not sure that there is a "default" value here - this carries the
> risk that future implementations will forget to implement this method
> and get the same value as Turing/Ampere. Could you instead use a
> `non_wpr_heap_size_tu102` method that is called by ga100/ga102 as well?

OK, will do that.


thanks,
-- 
John Hubbard