Re: [PATCH v11 13/22] gpu: nova-core: Hopper/Blackwell: add FMC signature extraction

[John Hubbard]

On 6/1/26 7:49 AM, Alexandre Courbot wrote:
> On Mon Jun 1, 2026 at 11:45 PM JST, Alexandre Courbot wrote:
>> On Sat May 30, 2026 at 12:09 PM JST, John Hubbard wrote:
...
>>> +        let mut signatures = KBox::new(
>>> +            FmcSignatures {
>>> +                hash384: [0; _],
>>> +                public_key: [0; _],
>>> +                signature: [0; _],
>>> +            },
>>> +            GFP_KERNEL,
>>> +        )?;
>>
>> This construct may create the 816 bytes long `FmcSignatures` instance on
>> the stack, where space is at a premium. `KBox::init` guarantees in-place

Ouch, that's huge. Good catch.

>> initialization:
>>
>>     let mut signatures = KBox::init(
>>         init!(FmcSignatures {
>>             hash384: [0; _],
>>             public_key: [0; _],
>>             signature: [0; _],
>>         }),
>>         )?;
>>         GFP_KERNEL,
>>
>> And by chaining the initializer we can also avoid making `signatures`
>> mutable:
>>
>>     let signatures = KBox::init(
>>         init!(FmcSignatures {
>>             hash384 <- Zeroable::init_zeroed(),
>>             public_key <- Zeroable::init_zeroed(),
>>             signature <- Zeroable::init_zeroed(),
> 
> Oops, I got a bit ahead of myself. The three lines above should be:
> 
>     hash384: [0; _],
>     public_key: [0; _],
>     signature: [0; _],
> 
> The rest should be working as expected.

OK, will fix this.

thanks,
-- 
John Hubbard