Re: [PATCH v4 2/3] arm64: dts: freescale: add Aquila iMX95 support

[Frank Li]

On Thu, May 21, 2026 at 07:11:05PM +0200, Franz Schnyder wrote:
> From: João Paulo Gonçalves <joao.goncalves@xxxxxxxxxxx>
>
> Add support for the Toradex Aquila iMX95 and its development carrier
> board.
>
> The module consists of an NXP i.MX95 family SoC, up to 16GB LPDDR5 RAM,
> up to 128GB of storage, a USB 3.2 OTG and USB 2.0 Host, a Gigabit
> Ethernet PHY, a 10 Gigabit Ethernet interface, an I2C EEPROM and
> Temperature Sensor, an RX8130 RTC, one Quad lane CSI interface, one Quad
> lane DSI or CSI interface, one LVDS interface (one or two channels), and
> some optional addons: DisplayPort (through a DSI-DP bridge), TPM 2.0,
> and a WiFi/BT module.
>
> Link: https://www.toradex.com/computer-on-modules/aquila-arm-family/nxp-imx95
> Link: https://www.toradex.com/products/carrier-board/aquila-development-board-kit
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@xxxxxxxxxxx>
> Co-developed-by: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> Co-developed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> Co-developed-by: Antoine Gouby <antoine.gouby@xxxxxxxxxxx>
> Signed-off-by: Antoine Gouby <antoine.gouby@xxxxxxxxxxx>
> Co-developed-by: Ernest Van Hoecke <ernest.vanhoecke@xxxxxxxxxxx>
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@xxxxxxxxxxx>
> Co-developed-by: Franz Schnyder <franz.schnyder@xxxxxxxxxxx>
> Signed-off-by: Franz Schnyder <franz.schnyder@xxxxxxxxxxx>
> ---
...
> +
> +	carrier_eeprom: eeprom@57 {
> +		compatible = "st,24c02", "atmel,24c02";

st,24c02 is not documented.

> +		reg = <0x57>;
> +		pagesize = <16>;
> +	};
> +};
...
> +
> +	/* Aquila GPIO_05 */
> +	pinctrl_gpio_5: gpio5grp {
> +		fsl,pins = <IMX95_PAD_ENET2_TD1__GPIO4_IO_BIT18	0x31e>; /* Aquila C21 */
> +	};
> +
> +	/* Aquila GPIO_06 */
> +	pinctrl_gpio_6: gpio6grp {
> +		fsl,pins = <IMX95_PAD_ENET2_TD2__GPIO4_IO_BIT17	0x31e>; /* Aquila C22 */
> +	};
> +
> +	/* Aquila GPIO_07 */
> +	pinctrl_gpio_7: gpio7grp {
> +		fsl,pins = <IMX95_PAD_ENET2_RXC__GPIO4_IO_BIT23	0x31e>; /* Aquila C23 */
> +	};
> +
> +	/* Aquila GPIO_08 */
> +	pinctrl_gpio_8: gpio8grp {
> +		fsl,pins = <IMX95_PAD_PDM_BIT_STREAM1__AONMIX_TOP_GPIO1_IO_BIT10	0x31e>; /* Aquila C24 */
> +	};

Please fix checkpatch worning, it exceed 100 char.

Frank