[PATCH] scsi: megaraid_mbox: avoid double kfree()

From: Arnd Bergmann

Date: Mon Jun 01 2026 - 17:02:37 EST


From: Arnd Bergmann <arnd@xxxxxxxx>

Smatch found a double-free after my recent change:

drivers/scsi/megaraid/megaraid_mbox.c:3474 megaraid_cmm_register()
error: double free of 'adp' (line 3468)

Since the object is no longer allocated in megaraid_cmm_register(),
remove the kfree() as well.

Fixes: c1f7275b613b ("scsi: megaraid_mbox: Reduce stack usage in megaraid_cmm_register()")
Reported-by: Dan Carpenter <error27@xxxxxxxxx>
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
drivers/scsi/megaraid/megaraid_mm.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_mm.c b/drivers/scsi/megaraid/megaraid_mm.c
index 60db48dc8f3a..e572665903d2 100644
--- a/drivers/scsi/megaraid/megaraid_mm.c
+++ b/drivers/scsi/megaraid/megaraid_mm.c
@@ -998,8 +998,6 @@ mraid_mm_register_adp(mraid_mmadp_t *adapter)

dma_pool_destroy(adapter->pthru_dma_pool);

- kfree(adapter);
-
return rval;
}

--
2.39.5