Re: [PATCH v12 20/22] gpu: nova-core: Hopper/Blackwell: add GSP lockdown release polling

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `io::` imports do not follow the vertical import sorting style.
--

commit 61efdca79645fc25a7eb578eb89ac5e6fa3b4971
Author: John Hubbard <jhubbard@xxxxxxxxxx>

gpu: nova-core: Hopper/Blackwell: add GSP lockdown release polling
    
On Hopper and Blackwell, FSP boots GSP with hardware lockdown enabled.
This commit adds the necessary register bit and helper functions to poll
for lockdown release before proceeding with GSP initialization.

> diff --git a/drivers/gpu/nova-core/gsp/hal/gh100.rs b/drivers/gpu/nova-core/gsp/hal/gh100.rs
> index f41f3fea15ff2..02aec52813894 100644
> --- a/drivers/gpu/nova-core/gsp/hal/gh100.rs
> +++ b/drivers/gpu/nova-core/gsp/hal/gh100.rs
> @@ -5,7 +5,13 @@
>  
>  use kernel::{
>      device,
> -    dma::Coherent, //
> +    dma::Coherent,
> +    io::{
> +        poll::read_poll_timeout,
> +        register::WithBase,
> +        Io, //
> +    },

[Severity: Low]
This isn't a bug, but should the io imports follow the alphabetical sorting
used in the Rust vertical import style? If so, Io would sort before poll and
register since uppercase letters come before lowercase in standard sorting.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602032111.224790-1-jhubbard@xxxxxxxxxx?part=20