Re: [PATCH v5 0/4] selftests/mm: refactor pkey helpers and fix mmap error handling

From: Hongfu Li

Date: Tue Jun 02 2026 - 00:58:54 EST


> > The main changes in this series are to refactor shared tracing and assertion
> > helpers into a common file, unify both pkey selftests on pkey_assert() and
> > per-test tracing for consistent diagnostics, and add missing mmap() return
> > checks with MAP_FAILED used throughout for readability and consistency.
>
> Thanks. AI review found a couple of legitimate-looking issues. At
> least one of these was also reported against the v2(?) series and you
> said you'd take a look. Were these things false positives?
>
> https://sashiko.dev/#/patchset/20260601061953.696844-1-lihongfu@xxxxxxxxxx

Thanks for pointing these out.
I initially suspected this one was a false positive, but upon recheck,
it also needs a fix. I will address both issues in the next revision.

Best regards,
Hongfu