Re: [PATCH 1/3] dt-bindings: net: qca,ipq5018: Split IPQ5018 PHY bindings from ar803x

[George Moussalem]

On 6/2/26 00:49, Rob Herring wrote:
> On Mon, Jun 01, 2026 at 12:45:25PM -0500, Rob Herring (Arm) wrote:
>>
>> On Mon, 01 Jun 2026 17:19:08 +0400, George Moussalem wrote:
>>> Move the definition for the Qualcomm IPQ5018 Internal PHY out of the
>>> qca,ar803x.yaml binding file and isolate them in a dedicated
>>> qca,ipq5018.yaml file. This is necessary due to the restriction of max
>>> one clock in ethernet-phy.yaml which ar803x references as further
>>> testing revealed that the RX and TX clocks of the IPQ5018 PHY need to
>>> be explicitly enabled.
> 
> Just splitting does not solve this problem as you can see with the 
> error. You will need to drop this constraint from ethernet-phy.yaml and 
> add it (1 clock) to every specific phy binding (that uses 'clocks').

Thanks for the advise, Rob. I've made changes accordingly and sent out
v2:
https://lore.kernel.org/netdev/20260602-ipq5018-gephy-clocks-v2-0-65a1f1d881f3@xxxxxxxxxxx/T/#t

Mind you that you'll likely still see an error coming from running 'make
dt_binding_check':

  DTC [C] Documentation/devicetree/bindings/net/renesas,ether.example.dtb
/home/george/src/linux-next/out/Documentation/devicetree/bindings/net/renesas,ether.example.dtb:
ethernet-phy@1 (ethernet-phy-id0022.1537): compatible:
['ethernet-phy-id0022.1537', 'ethernet-phy-ieee802.3-c22'] is too long
	from schema $id: http://devicetree.org/schemas/net/micrel.yaml

This was already there and I checked against master.

> 
>>>
>>> Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
>>> ---
>>>  .../devicetree/bindings/net/qca,ar803x.yaml        | 43 -------------
>>>  .../devicetree/bindings/net/qca,ipq5018.yaml       | 75 ++++++++++++++++++++++
>>>  2 files changed, 75 insertions(+), 43 deletions(-)
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/qca,ipq5018.example.dtb: ethernet-phy@7 (ethernet-phy-id004d.d0c0): clocks: [[4294967295, 36], [4294967295, 37]] is too long
>> 	from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.kernel.org/project/devicetree/patch/20260601-ipq5018-gephy-clocks-v1-1-2df8287712c3@xxxxxxxxxxx
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your schema.
>>
>>

Best regards,
George