Re: [PATCH v3 0/2] gpiolib: acpi: Fix bounds-checking and connection leak
From: Andy Shevchenko
Date: Tue Jun 02 2026 - 03:51:05 EST
On Wed, May 20, 2026 at 09:45:45AM +0200, Marco Scardovi (scardracs) wrote:
> Hi Andy,
>
> This new series addresses two issues in the ACPI GPIO library while trying
> to address your feedbacks:
> 1. Adds robust bounds checking for pin resource indexing when requesting
> owned descriptors and querying wakeup/interrupt pin configurations.
> 2. Fixes a connection/descriptor leak in the OpRegion address space
> handler and handles connection rollback in a transaction-local list
> to avoid wiping successfully established connections.
>
> Please note that some of these changes were found during a personal follow up
> analysis before submitting the patches to the community. They are reported
> to explain why some of these fixes are made in that way instead of another.
Thanks for the update!
Please, split the second patch more to make it better to understand what the
helpers are doing (without changing the behaviour) and then fix the problem.
Otherwise it looks better than previous attempts.
--
With Best Regards,
Andy Shevchenko