Re: [PATCH rdma-next v6] RDMA: Change capability fields in ib_device_attr from int to u32

From: Andy Shevchenko

Date: Tue Jun 02 2026 - 05:29:45 EST


On Mon, Jun 01, 2026 at 08:51:40AM -0700, Bart Van Assche wrote:
> On 6/1/26 2:25 AM, Erni Sri Satya Vennela wrote:

...

> > - sdev->srq_size = min(srpt_srq_size, sdev->device->attrs.max_srq_wr);
> > + sdev->srq_size = min_t(u32, srpt_srq_size, sdev->device->attrs.max_srq_wr);
>
> min_t() shouldn't be used if there is an alternative available. For the
> SRP drivers, please make sure that both arguments of min() are unsigned
> instead of using min_t().

Ah, I just answered in similar way against v5. I also mentioned clamp() there.

--
With Best Regards,
Andy Shevchenko