Re: [PATCH v3 1/3] media: ipu-bridge: Add DMI information of Lenovo X9 to the image upside-down list

[Kate Hsuan]

Hi Damjan,

Thank you for your review.

On Sat, May 30, 2026 at 6:33 AM Damjan Georgievski <gdamjan@xxxxxxxxx> wrote:
>
> On 5/22/26 05:11, Kate Hsuan wrote:
> > The Lenovo X9 has an upside-down-mounted Sony IMX471 sensor so the image
> > was displayed upside-down. Add the DMI information of Lenovo X9 to
> > resolve the issue.
> >
> > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx>
> > ---
> >   drivers/media/pci/intel/ipu-bridge.c | 14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> > index 32cc95a766b7..1c3364451fa3 100644
> > --- a/drivers/media/pci/intel/ipu-bridge.c
> > +++ b/drivers/media/pci/intel/ipu-bridge.c
> > @@ -118,6 +118,20 @@ static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {
> >               },
> >               .driver_data = "OVTI02C1",
> >       },
> > +     {
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > +                     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X9-14"),
>
> Isn't this going to be an issue in the future if/when a "Gen 2" appears?

You can look into the v1 [1]. The DMI_BOARD_NAME is used to
distinguish the types of X1.
v3 covers wider ranges of X9-14 and 15. If we agree with v1, I can
revert this patch to v1.

[1] https://lore.kernel.org/linux-media/20260417083214.222189-2-hpa@xxxxxxxxxx/

>
> Just extrapolation from my older laptop, it shows "ThinkPad X1 Carbon
> 5th" for "/sys/class/dmi/id/product_version"
>
> > +             },
> > +             .driver_data = "SONY471A",
> > +     },
> > +     {
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > +                     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X9-15"),
> > +             },
> > +             .driver_data = "SONY471A",
> > +     },
> >       {} /* Terminating entry */
> >   };
> >
>



-- 
BR,
Kate