Re: [PATCH v2] arm64: dts: freescale: fsl-ls1028a-tqmls1028a-mbls1028a: switch mmc aliases

[Nora Schiffer]

On Wed, 2026-04-01 at 13:31 +0200, Nora Schiffer wrote:
> On Tue, 2026-03-17 at 09:29 +0100, Nora Schiffer wrote:
> > On Tue, 2026-02-24 at 16:25 +0100, Nora Schiffer wrote:
> > > All modern TQ-Systems boards follow the convention that mmc0 is the eMMC
> > > and mmc1 is the SD-card when both interfaces exist, reducing differences
> > > between boards for both documentation and U-Boot code (which uses the
> > > same Device Trees). Adjust the recently added MBLS1028A Device Tree
> > > accordingly.
> > > 
> > > Fixes: 0538ca1f102d ("arm64: dts: ls1028a: Add mbls1028a and mbls1028a-ind devicetrees")
> > > Signed-off-by: Nora Schiffer <nora.schiffer@xxxxxxxxxxxxxxx>
> > > Reviewed-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > > Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> > > ---
> > > 
> > > v2:
> > > - updated author information after name change
> > > - collected review tags
> > > 
> > > As mentioned in the v1 submission, it would be great to get this in
> > > before v7.0, as the TQMLS1028A/MBLS1028A was just added in the current
> > > development cycle, and we'd like to avoid changing the aliases after the
> > > DTS was part of a mainline kernel release.
> > > 
> > > Best,
> > > Nora
> > 
> > 
> > Hi Frank,
> > 
> > can we get this applied, so the change makes it into v7.0?
> > 
> > Best,
> > Nora
> 
> Hi Frank,
> 
> is there still time for this patch to make it into v7.0? If not, it would be
> great to have this applied early in the v7.1 development cycle, so it can get
> backported to 7.0.y before anyone starts relying on the current order of mmc
> devices.
> 
> Best,
> Nora

Hi Frank,

how should we proceed with this? You provided your Reviewed-by months ago, but
the patch never got applied. It is also marked as 'archived' in patchwork:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20260224152523.570057-1-nora.schiffer@xxxxxxxxxxxxxxx/


I'm not sure if changing the aliases at this point would be too much of a
breaking change... would it make sense to resubmit it, or should I consider it
rejected?

Best,
Nora


> 
> 
> 
> > 
> > 
> > 
> > > 
> > > 
> > >  .../boot/dts/freescale/fsl-ls1028a-tqmls1028a-mbls1028a.dtsi  | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-tqmls1028a-mbls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a-tqmls1028a-mbls1028a.dtsi
> > > index cf338b2e80064..426a81e1743f1 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-tqmls1028a-mbls1028a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-tqmls1028a-mbls1028a.dtsi
> > > @@ -17,8 +17,8 @@ aliases {
> > >  		gpio0 = &gpio1;
> > >  		gpio1 = &gpio2;
> > >  		gpio2 = &gpio3;
> > > -		mmc0 = &esdhc; /* SD-Card */
> > > -		mmc1 = &esdhc1; /* eMMC */
> > > +		mmc0 = &esdhc1; /* eMMC */
> > > +		mmc1 = &esdhc; /* SD-Card */
> > >  		serial0 = &duart0;
> > >  		serial1 = &duart1;
> > >  	};
> > 
> 

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/