Re: [RFC PATCH 2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure

[Miquel Raynal]

On 01/06/2026 at 14:52:44 +02, Michael Walle <mwalle@xxxxxxxxxx> wrote:

> This was introduced in commit 548ed6847f530 ("mtd: spi-nor: Add the
> SNOR_F_4B_OPCODES flag"). It looks like it was the rollback mechanism if
> parsing the SFDP failed, but was setting that flag first. Nowadays, that
> flag can only be set if spi_nor_parse_4bait() was successful. IOW, the
> flags won't be left in an undefined state if parsing SFDP fails.
>
> Remove the unneeded code to be able to rework spi_nor_init_params().
>
> Signed-off-by: Michael Walle <mwalle@xxxxxxxxxx>

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>