Re: [PATCH v4 07/12] rvtrace: Add trace ramsink driver

[Mayuresh Chitale]

Hi Sergey,

On Sat, May 23, 2026 at 1:34 AM Sergey Matyukevich <geomatsi@xxxxxxxxx> wrote:
>
> On Wed, Apr 29, 2026 at 06:21:30PM +0530, Anup Patel wrote:
> > From: Mayuresh Chitale <mayuresh.chitale@xxxxxxxxxxxxxxxx>
> >
> > Add initial implementation of RISC-V trace ramsink driver. The ramsink
> > is defined in the RISC-V Trace Control Interface specification.
> >
> > Co-developed-by: Anup Patel <anup.patel@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Mayuresh Chitale <mayuresh.chitale@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/hwtracing/rvtrace/Kconfig           |   9 +
> >  drivers/hwtracing/rvtrace/Makefile          |   1 +
> >  drivers/hwtracing/rvtrace/rvtrace-ramsink.c | 338 ++++++++++++++++++++
> >  3 files changed, 348 insertions(+)
> >  create mode 100644 drivers/hwtracing/rvtrace/rvtrace-ramsink.c
>
> ...
>
> > +static int rvtrace_ramsink_probe(struct rvtrace_component *comp)
> > +{
> > +     int ret;
> > +
> > +     ret = rvtrace_ramsink_setup(comp);
> > +     if (ret)
> > +             return dev_err_probe(&comp->dev, ret, "failed to setup ramsink.\n");
> > +
> > +     ret = rvtrace_enable_component(comp->pdata);
>
> Does it make sense to enable such components (ramsink and encoder) on probe ?
> IIUC they will be enabled/disabled later in start/stop operations when
> rvtrace graph is activated e.g. during perf tool work. It looks like
> reset (primary activation) should be sufficient, and it is already done
> by the core framework on probing.
Yes, that is correct. I will fix in the next version.
>
> > +     if (ret)
> > +             return dev_err_probe(&comp->dev, ret, "failed to enable ramsink.\n");
> > +
> > +     return ret;
> > +}
>
> Regards,
> Sergey