Re: [PATCH net-next v3 08/14] net: ethernet: oa_tc6: Remove FCS size in RX frame

From: Andrew Lunn

Date: Tue Jun 02 2026 - 08:07:07 EST


On Tue, Jun 02, 2026 at 02:40:13AM +0000, Selvamani Rajagopal wrote:
> >
> > On Fri, May 29, 2026 at 06:41:00PM +0000, Selvamani Rajagopal wrote:
> > > When MAC-PHY appends FCS to the incoming frame, FCS,
> > > it is removed from the frame before passing it to the stack.
> >
> > What is missing from this commit message is an answer to the question
> > "Why?". Does the stack do something wrong if there is a FCS at the end
> > of the frame?
>
> That was a little mystery to me as well when our SQA alerted me with the issue.
> When I tested, ping worked fine without any issue even with the frames with FCS appended.
> But strangely ptp4l utility failed with invalid data size. Once we removed FCS, it worked fine.
>
> Will add this reason in the commit message.

Please take a look at NETIF_F_RXFCS.

Andrew