Re: [PATCH] iio: adc: ad4080: fix AD4880 chip ID
From: Jonathan Cameron
Date: Tue Jun 02 2026 - 08:50:25 EST
On Tue, 2 Jun 2026 11:01:24 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
> On Tue, 2 Jun 2026 at 10:52, Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> wrote:
> >
> > The AD4880 chip ID was incorrectly set to 0x0750. According to the
> > datasheet, the product ID registers read 0x00 (PRODUCT_ID_H) and 0x59
> > (PRODUCT_ID_L), giving a combined chip ID of 0x0059. Fix the value to
> > match the actual hardware.
> >
> > Fixes: 35fc53e802bf ("iio: adc: ad4080: add support for AD4880 dual-channel ADC")
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> > ---
>
> Sashiko failed to apply your patch, are you developing against
> an old tree?
Other way around. This is only in the iio tree and sashiko seems to
use either mainline or next, I haven't figured out which.
>
> Codewise LGTM.
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
>
Applied but I dropped the fixes tag because it causes pain for me to have
references within my tree near merge windows and it will all be in the same
pull request anyway. Note it had changed because I had to do some surgery
on the tree a few days ago.