Re: [PATCH v2] firmware: meson: sm: add stub functions when CONFIG_MESON_SM is disabled

[Ronald Claveau]

On 6/2/26 2:15 PM, Daniel Lezcano wrote:
> On 6/2/26 13:58, Ronald Claveau wrote:
>> On 6/2/26 11:57 AM, Daniel Lezcano wrote:
>>> On 5/31/26 21:58, Daniel Lezcano wrote:
>>>> On 5/31/26 19:49, Ronald Claveau wrote:
>>>>> On 5/31/26 10:41 AM, Daniel Lezcano wrote:
>>>>>> On 5/31/26 09:51, Ronald Claveau via B4 Relay wrote:
>>>>>>> From: Ronald Claveau <linux-kernel-dev@xxxxxxxx>
>>>>
>>>> [ ... ]
> 
> [ ... ]
> 
>> Sorry for the delay.
>> The module issue was raised by the test robot here
>> https://lore.kernel.org/oe-kbuild-all/202605310154.bmdMBZHJ-
>> lkp@xxxxxxxxx/
>>
>> If I understand correctly we can drop this stub change and only use a
>> "depends on MESON_SM" for the "AMLOGIC_THERMAL" config, is it correct ?
> 
> Yes, that is the simplest solution for now
> 
> Indirectly related, where is the mod dependency telling meson_sm must be
> loaded before the amlogic thermal driver ?

I think depmod should detect the symbol usage and add it to the
modules.dep file to give the correct order. Do you think it would not
work here ?

-- 
Best regards,
Ronald