Re: [PATCH] ASoC: tas2783: Update loaded firmware names to linux-firmware 20260519

[Mark Brown]

On Tue, Jun 02, 2026 at 07:53:59PM +0200, Bartosz Juraszewski wrote:

> This same commit removes all 22 symlinks from WHENCE, that used naming
> without the '0x' prefix to only 6 prevoiusly existing .bin files.

So there will be existing userspace using the old names.

> This patch adds `0x` prefix explicitly to the generated firmware name
> allowing file to successfully load. This results in functioning audio on
> my device - ASUS ProArt PX13 HN7306EAC, which uses 1714-1-0x8.bin and
> 1714-1-0xB.bin firmware files.

>  	for (; dev; dev = dev->parent) {
>  		if (dev->bus == &pci_bus_type) {
>  			pci = to_pci_dev(dev);
> -			scnprintf(name, size, "%04X-%1X-%1X.bin",
> +			scnprintf(name, size, "%04X-%1X-0x%1X.bin",
>  				  pci->subsystem_device, bus->link_id, unique_id);

This will only use the new name, meaning that an existing working
install will be broken when upgrading the kernel unless linux-firmware
is also updated.  We should try both names, assuming the change in name
stays, so that existing installs continue to work.

Attachment: signature.asc
Description: PGP signature