Re: [PATCH] net: qrtr: fix node refcount leak on ctrl packet alloc failure

From: Markus Elfring

Date: Tue Jun 02 2026 - 14:55:35 EST



> > Add qrtr_node_release(node) before returning on the allocation failure
> > path to properly release the reference.

> Here is the summary with links:
> - net: qrtr: fix node refcount leak on ctrl packet alloc failure
> https://git.kernel.org/netdev/net-next/c/3b09ff541145

Would it have been possible to avoid a bit of duplicate source code
by using an additional label in the implementation of the function “qrtr_send_resume_tx”?
https://elixir.bootlin.com/linux/v7.1-rc6/source/net/qrtr/af_qrtr.c#L998-L1024
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.1-rc6#n526

Regards,
Markus