Re: [PATCH 07/12] iio: dac: ad5686: add ldac gpio

[Andy Shevchenko]

On Tue, Jun 02, 2026 at 05:33:54PM +0100, Rodrigo Alencar via B4 Relay wrote:

> If wired LDAC, should be held low when unused (pin is active-low), which
> allows for synchronous DAC updates. This will be used to update all the
> channels at the same time when adding buffer support.

...

> --- a/drivers/iio/dac/ad5686.h
> +++ b/drivers/iio/dac/ad5686.h
> @@ -9,6 +9,7 @@
>  #define __DRIVERS_IIO_DAC_AD5686_H__
>  
>  #include <linux/bits.h>
> +#include <linux/gpio/consumer.h>

No user of this. C-file is the one you should include this in.
Hint: The opaque pointers can be just forward declared.

>  #include <linux/mutex.h>
>  #include <linux/types.h>

-- 
With Best Regards,
Andy Shevchenko