Re: [PATCH net-next v5 2/4] net: rnpgbe: Add basic TX packet transmission support

[Jakub Kicinski]

On Thu, 28 May 2026 10:31:48 +0800 Dong Yibo wrote:
> +static int rnpgbe_maybe_stop_tx(struct mucse_ring *tx_ring, u16 size)
> +{
> +	if (likely(mucse_desc_unused(tx_ring) >= size))
> +		return 0;
> +
> +	netif_stop_subqueue(tx_ring->netdev, tx_ring->queue_index);
> +	/* Herbert's original patch had:
> +	 *  smp_mb__after_netif_stop_queue();
> +	 * but since that doesn't exist yet, just open code it.
> +	 */
> +	smp_mb();
> +
> +	/* We need to check again in a case another CPU has just
> +	 * made room available.
> +	 */
> +	if (likely(mucse_desc_unused(tx_ring) < size))
> +		return -EBUSY;
> +
> +	/* A reprieve! - use start_queue because it doesn't call schedule */
> +	netif_start_subqueue(tx_ring->netdev, tx_ring->queue_index);
> +
> +	return 0;
> +}

please use existing helpers from include/net/netdev_queues.h
-- 
pw-bot: cr