Re: [PATCH v2 3/3] x86/mm: drop unused returns from direct map setup functions

From: Dave Hansen

Date: Tue Jun 02 2026 - 17:40:56 EST


On 5/3/26 06:04, Brendan Jackman wrote:
> Nothing looks at these return values. Furthermore, as discussed in [0],
> it seems like in the case of a pre-existing 4K mapping, the return value
> of kernel_physical_mapping_init() is wrong anyway. So, just stop
> returning a value.

Oh, this is a really nice simplification. That code is not fun. Thanks
for figuring it out!

Assuming we can get the changelog worked out for 2/3:

Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>