Re: [PATCH net-next v5 2/2] net: dsa: mv88e6xxx: add support for credit based shaper

From: Luke Howard

Date: Tue Jun 02 2026 - 19:12:20 EST




> On 2 Jun 2026, at 7:10 pm, Cedric Jehasse via B4 Relay <devnull+cedric.jehasse.luminex.be@xxxxxxxxxx> wrote:
>
> + int hilimit_reg;
> + int rate_reg;
> + u8 queue_bit;
> + u16 hi_limit;

One nitpick is that it might be nice to consistently spell hilimit (vs hi_limit).

Reviewed-by: Luke Howard <lukeh@xxxxxxxx>