Re: [PATCH v2 3/5] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons

[Dmitry Torokhov]

On Wed, Jun 03, 2026 at 02:45:34AM +0300, Andy Shevchenko wrote:
> On Tue, Jun 02, 2026 at 03:06:14PM -0700, Dmitry Torokhov wrote:
> > On Wed, Jun 03, 2026 at 01:02:56AM +0300, Andy Shevchenko wrote:
> > > On Wed, May 20, 2026 at 10:13:19PM -0700, Dmitry Torokhov wrote:
> 
> ...
> 
> > > > +	for (i = 0; i < ARRAY_SIZE(rsk7203_devices); i++) {
> > > 
> > > 	for (unsigned int i = 0; i < ARRAY_SIZE(rsk7203_devices); i++) {
> > > 
> > > ...and drop the above definition of i.
> > 
> > Why? I do not see coding style suggesting this. 
> 
> Linus Torvalds.

Context matters.

If you want this to be a universal requirement work on adding this to
coding style and to checkpatch. Otherwise declaring loop iterator inside
the loop can be beneficial but in many cases it does not really matter
and can be left to the code author and the revealing style for the
affected code area.

Thanks.

-- 
Dmitry