Re: [PATCH v3 15/19] mm/hugetlb_vmemmap: Move bootmem HVO setup to early init
From: Muchun Song
Date: Tue Jun 02 2026 - 22:45:07 EST
> On Jun 2, 2026, at 23:41, Mike Rapoport <rppt@xxxxxxxxxx> wrote:
>
> On Tue, 02 Jun 2026 18:10:35 +0800, Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote:
>> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
>> index ea6af85bfec1..464578ee246e 100644
>> --- a/mm/hugetlb_vmemmap.c
>> +++ b/mm/hugetlb_vmemmap.c
>> @@ -745,6 +745,8 @@ static bool vmemmap_should_optimize_bootmem_page(struct huge_bootmem_page *m)
>> return true;
>> }
>>
>> +static struct zone *pfn_to_zone(unsigned nid, unsigned long pfn);
>> +
>
> Can we please move the entire function rather than add a forward
> declaration?
Yes. Will update next version.
>
> Other than that
>
> Acked-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
Thanks.
>
> --
> Sincerely yours,
> Mike.
>