Re: [PATCH v2 0/3] selftests/damon: misc fixes for test bugs
From: Kunwu Chan
Date: Wed Jun 03 2026 - 05:18:27 EST
2026年6月3日 13:02, "SeongJae Park" <sj@xxxxxxxxxx mailto:sj@xxxxxxxxxx?to=%22SeongJae%20Park%22%20%3Csj%40kernel.org%3E > 写到:
>
> On Wed, 03 Jun 2026 02:11:33 +0000 "Kunwu Chan" <kunwu.chan@xxxxxxxxx> wrote:
>
> >
> > 2026年6月1日 22:22, "SeongJae Park" <sj@xxxxxxxxxx mailto:sj@xxxxxxxxxx?to=%22SeongJae%20Park%22%20%3Csj%40kernel.org%3E > 写到:
> >
> >
> >
> > On Mon, 1 Jun 2026 11:23:11 +0800 Kunwu Chan <kunwu.chan@xxxxxxxxx> wrote:
> >
> > >
> > > From: Kunwu Chan <chentao@xxxxxxxxxx>
> > >
> > > This series fixes several bugs in the DAMON selftests. Most are
> > > trivial but cause tests to silently pass when they shouldn't, or
> > > fail prematurely on slow machines.
> > >
> > Nit. Only patch 3 fixes a fake test pass for "avail_operations" file existence
> > test, and the series is not doing something for slow machines, right? I think
> > the last sentence should be updated, for example:
> >
> > '''
> > Most are trivial but makes test output wrong or even silently pass the one for
> > 'avail_operation' file existence check.
> > '''
> >
> > Other than that, all look good to me, and already have my Reviewed-by: tag.
> >
> > Asssuming you are ok with the above change, I applied this series to damon/next
> > [1] tree with the above change. If this series is not added to mm.git in short
> > term (~1 week?), I will ask mm.git maintainer (Andrew Morton) to pick this.
> >
> FYI, we are now quite close to next merge window. We want to focus on making
> mm.git more stabilized and therefore ready for the next merge window, rather
> than adding more changes that no really urgent. I understand this series is
> not really urgent. Hence, I will request adding this to mm.git after next -rc1
> release. Let me know if you think this is really urgent.
>
Waiting until after -rc1 is perfectly fine, this series isn't
urgent. Thanks for letting me know.
Regards,
Kunwu
> >
> > So, no action from your side is needed for now. If it seems I also forgot
> > doing that or you cannot wait for my action, please feel free to directly ask
> > that to Andrew.
> >
> > [1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
> >
> > Hi SJ,
> >
> > The updated cover letter looks good to me, thanks for fixing it.
> > Thanks also for applying to damon/next.
> > No further action needed on my side.
> >
> Thank you for confirming!
>
> Thanks,
> SJ
>
> [...]
>