Re: [PATCH] mm/mincore: handle non-swap entries before !CONFIG_SWAP guard

[Usama Arif]

On 02/06/2026 18:51, Pedro Falcato wrote:
> On Tue, Jun 02, 2026 at 10:22:47AM -0700, Usama Arif wrote:
>> mincore_swap() also fields migration/hwpoison entries (and shmem
>> swapin-error entries), which can exist on !CONFIG_SWAP builds when
>> CONFIG_MIGRATION or CONFIG_MEMORY_FAILURE is enabled.  The
>> !IS_ENABLED(CONFIG_SWAP) guard ran before the non-swap-entry early
>> return, so mincore_pte_range() can spuriously WARN and report these
>> pages nonresident on !CONFIG_SWAP kernels.
>>
>> Move the guard below the non-swap-entry check so only true swap
>> entries trip the WARN, and migration/hwpoison entries take the
>> existing "uptodate / non-shmem" path.
>>
>> Fixes: 1f2052755c15 ("mm/mincore: use a helper for checking the swap cache")
>> Signed-off-by: Usama Arif <usama.arif@xxxxxxxxx>
> 
> LGTM, thanks!
> 
> Reviewed-by: Pedro Falcato <pfalcato@xxxxxxx>
> 
> Maybe Cc: stable@xxxxxxxxxx ?
> 

Ah yes, I have cc-ed stable in the reply to this email, but probably that
is not enough?

Thanks