Re: [PATCH v4 3/5] tools/lib/mm: move hugepage_settings out of selftests

From: Mike Rapoport

Date: Wed Jun 03 2026 - 06:03:14 EST


On Wed, 27 May 2026 19:54:30 +0530, Sarthak Sharma <sarthak.sharma@xxxxxxx> wrote:

Hi Sarthak,

>
> diff --git a/tools/testing/selftests/mm/hugepage_settings.c b/tools/lib/mm/hugepage_settings.c
> similarity index 97%
> rename from tools/testing/selftests/mm/hugepage_settings.c
> rename to tools/lib/mm/hugepage_settings.c
> index c2f97fe97e58..c75b9c8f4a74 100644
> --- a/tools/testing/selftests/mm/hugepage_settings.c
> +++ b/tools/lib/mm/hugepage_settings.c
> @@ -419,8 +424,8 @@ int detect_hugetlb_page_sizes(unsigned long sizes[], int max)
> if (sscanf(entry->d_name, "hugepages-%zukB", &kb) != 1)
> continue;
> sizes[count++] = kb * 1024;
> - ksft_print_msg("[INFO] detected hugetlb page size: %zu KiB\n",
> - kb);
> + fprintf(stderr, "# [INFO] detected hugetlb page size: %zu KiB\n",
> + kb);

ksft_print_msg() prints to stdout, let's keep it for now.

--
Sincerely yours,
Mike.