Re: [PATCH v3 14/15] pmdomain: mediatek: airoha: use clk_determine_rate_noop()

[Ulf Hansson]

On Wed, May 6, 2026 at 2:49 AM Brian Masney <bmasney@xxxxxxxxxx> wrote:
>
> Drop the driver-specific empty determine_rate() function and use the new
> shared clk_determine_rate_noop() helper.
>
> Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>

Acked-by: Ulf Hansson <ulfh@xxxxxxxxxx>

Kind regards
Uffe

> ---
> To: Ulf Hansson <ulfh@xxxxxxxxxx>
> To: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> To: Michael Turquette <mturquette@xxxxxxxxxxxx>
> To: Stephen Boyd <sboyd@xxxxxxxxxx>
> To: Brian Masney <bmasney@xxxxxxxxxx>
> Cc: linux-clk@xxxxxxxxxxxxxxx
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
> ---
>  drivers/pmdomain/mediatek/airoha-cpu-pmdomain.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/pmdomain/mediatek/airoha-cpu-pmdomain.c b/drivers/pmdomain/mediatek/airoha-cpu-pmdomain.c
> index 3b1d202f89dc..5efd7a38f4da 100644
> --- a/drivers/pmdomain/mediatek/airoha-cpu-pmdomain.c
> +++ b/drivers/pmdomain/mediatek/airoha-cpu-pmdomain.c
> @@ -21,12 +21,6 @@ struct airoha_cpu_pmdomain_priv {
>         struct generic_pm_domain pd;
>  };
>
> -static int airoha_cpu_pmdomain_clk_determine_rate(struct clk_hw *hw,
> -                                                 struct clk_rate_request *req)
> -{
> -       return 0;
> -}
> -
>  static unsigned long airoha_cpu_pmdomain_clk_get(struct clk_hw *hw,
>                                                  unsigned long parent_rate)
>  {
> @@ -48,7 +42,7 @@ static int airoha_cpu_pmdomain_clk_is_enabled(struct clk_hw *hw)
>  static const struct clk_ops airoha_cpu_pmdomain_clk_ops = {
>         .recalc_rate = airoha_cpu_pmdomain_clk_get,
>         .is_enabled = airoha_cpu_pmdomain_clk_is_enabled,
> -       .determine_rate = airoha_cpu_pmdomain_clk_determine_rate,
> +       .determine_rate = clk_determine_rate_noop,
>  };
>
>  static int airoha_cpu_pmdomain_set_performance_state(struct generic_pm_domain *domain,
>
> --
> 2.54.0