Re: [PATCH v2 1/8] x86/cpu/hygon: Adjust the die_id and logical_die_id for Hygon models 0x4-0x8

[Fu Hao]

On 6/3/2026 10:26 AM, Borislav Petkov wrote:
> On Tue, Apr 07, 2026 at 04:22:42PM +0800, Fu Hao wrote:
> > The die ID should be got from the NodeId field of CPUID leaf 0x8000001e
> > ecx for Hygon models 0x4-0x8 processors.
>
> Correct the formulations in this text: "The die ID should be got from the
> NodeId field of CPUID leaf 0x8000001e ecx for Hygon models 0x4-0x8
> processors."
>
> AI:
>
> 	Here are some corrected versions of your sentence:
> 	
> 	Option 1 (minimal changes): "The die ID should be obtained from the
> 	NodeId field of CPUID leaf 0x8000001e ECX for Hygon processors of
> 	models 0x4–0x8."
>
> 	Option 2 (more natural phrasing): "The die ID should be read from the
> 	NodeId field of CPUID leaf 0x8000001e (ECX) for Hygon processor models
> 	0x4–0x8."
>
> 	Option 3 (concise): "For Hygon processor models 0x4–0x8, the die ID
> 	should be obtained from the NodeId field in ECX of CPUID leaf
> 	0x8000001e."
>
> 	Key issues corrected:
> 	
> 	    "should be got" → "should be obtained" / "should be read" (more formal and grammatically preferred)
> 	    "ecx" → "ECX" (CPU register names are conventionally capitalized)
> 	    "Hygon models 0x4-0x8 processors" → "Hygon processor models 0x4–0x8" (clearer word order)
> 	    Consider using an en dash (–) instead of a hyphen (-) for the range, though a hyphen is acceptable in code comments.
>
>
> Now you do it for all your commit messages please.

Hi Boris,

    Thank you very much for reviewing this patch and providing such
detailed guidance. Please accept my apologies for the non-compliant
patch comments and commit messages in the previous version, and I
will fix it in v3.

--
Regards,
Fu Hao