Re: [PATCH v2 6/9] mailbox: imx: Move the RX part of the mailbox into the threaded handler

[Daniel Baluta]

On 6/3/26 16:20, Sebastian Andrzej Siewior wrote:
> On 2026-06-03 16:18:22 [+0300], Daniel Baluta wrote:
>> On 6/3/26 16:05, Sebastian Andrzej Siewior wrote:
>>> Move RX callback handling into the threaded handler. This is similar to
>>> the TX side except that we explicitly mask the source interrupt in the
>>> primary handler and unmask it in the threaded handler again after
>>> success. This was done automatically in the TX part.
>>>
>>> The masking/ unmasking can be removed from imx_mu_specific_rx() since it
>>> already happens in the primary/ threaded handler before invoking the
>>> channel specific callback.
>>>
>>> Move RX channel handling into threaded handler.
>>
>> Hi Sebastian,
>>
>> It is not very clear from me from the commit message why this change is needed.
>> Can you please update the commit message with proper explanation?
> 
> The intention is to move the entire interrupt handling into the threaded
> handler. The primary handler masks just event, the threaded handler
> performs the RX/TX/ event.
> I move the individual events step by step so the previous patch moved
> the TX, here is RX and the next one does RXDB.
> 
> Is this clear now? The cover later explains why this done in the first
> place.

I would prefer to add the explanation for this in at least one commit
message to be there in git log.

Cover letter is not kept in git history.