[PATCH] scripts/sorttable: guard long_size under MCOUNT_SORT_ENABLED
From: Dakkshesh
Date: Wed Jun 03 2026 - 15:21:11 EST
clang's -Wunused-but-set-global (a sub-warning of
-Wunused-but-set-variable, enabled via -Wall), points out an
unused static global variable in scripts/sorttable.c:
scripts/sorttable.c:452:12: error: variable 'long_size' set but not
used [-Werror,-Wunused-but-set-variable]
long_size is only read inside MCOUNT_SORT_ENABLED blocks. In upstream,
it is implicitly resolved by commit b055f4c431e3 ("sorttable: Move ELF
parsing into scripts/elf-parse.[ch]") which refactors the file entirely.
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Dakkshesh <beakthoven@xxxxxxxxx>
---
scripts/sorttable.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/sorttable.c b/scripts/sorttable.c
index deed676bf..674b24a97 100644
--- a/scripts/sorttable.c
+++ b/scripts/sorttable.c
@@ -449,7 +449,9 @@ static inline void *get_index(void *start, int entsize, int index)
}
static int extable_ent_size;
+#ifdef MCOUNT_SORT_ENABLED
static int long_size;
+#endif
#define ERRSTR_MAXSZ 256
@@ -1311,7 +1313,9 @@ static int do_file(char const *const fname, void *addr)
};
e = efuncs;
+#ifdef MCOUNT_SORT_ENABLED
long_size = 4;
+#endif
extable_ent_size = 8;
if (r2(&ehdr->e32.e_ehsize) != sizeof(Elf32_Ehdr) ||
@@ -1348,7 +1352,9 @@ static int do_file(char const *const fname, void *addr)
};
e = efuncs;
+#ifdef MCOUNT_SORT_ENABLED
long_size = 8;
+#endif
extable_ent_size = 16;
if (r2(&ehdr->e64.e_ehsize) != sizeof(Elf64_Ehdr) ||
--
2.54.0