Re: [PATCH v4] arm64: dts: qcom: monaco-arduino-monza: Add QCNFA725B WiFi support

[Qian Zhang]

On Wed, Jun 3, 2026 at 10:04 PM Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
>
>
> On 31-May-26 09:14, Qian Zhang wrote:
> > Add support for the QCNFA725B M.2 WiFi module (WCN6855-based) connected
> > to PCIe0 on the Arduino VENTUNO Q board. The following DT nodes are
> > required:
> >
> > - qcom,wcn6855-pmu: manages GPIO56 (wlan_en) through the
> >   pwrseq-qcom-wcn power sequencer, and exposes the WCN6855 internal
> >   LDO regulators consumed by the wifi@0 node.
> >
> > - rfkill-gpio: exposes GPIO54 to the rfkill subsystem for RF state
> >   management.
> >
> > - wifi@0: describes the WCN6855 endpoint on the PCI tree.
> >
> > Signed-off-by: Qian Zhang <qian.zhang@xxxxxxxxxxxxxxxx>
> > ---
>
> [...]
>
> > +     rfkill-wlan {
> > +             compatible = "rfkill-gpio";
> > +             label = "wlan";
> > +             radio-type = "wlan";
> > +             shutdown-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
> > +
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&wlrfkill_default_state>;
>
> property-n
> property-names
>
> in this order, please, everywhere
>
> [...]
>
> > +             vddio-supply    = <&vdc_3v3>;
>
> Just one space before the equal sign and one space after
>
> [...]
>
> > +             pci@1,0 {
>
> pcie@
>
> [...]
>
> > +     wlan_en_state: wlan-en-state {
> > +             pins = "gpio56";
> > +             function = "gpio";
> > +             output-low;
>
> The driver that you pass a reference to GPIO56 already controls
> the output state, drop output-low
>
> Konrad
Will fix all the issues.

Thanks,
Qian