Re: [PATCH v3 2/2] selftests/bpf: Cover tail-call cgroup storage prog-array checks

[bot+bpf-ci]

> diff --git a/tools/testing/selftests/bpf/prog_tests/tailcalls.c b/tools/testing/selftests/bpf/prog_tests/tailcalls.c
> index 7d534fde0af9..f8c4b569da95 100644
> --- a/tools/testing/selftests/bpf/prog_tests/tailcalls.c
> +++ b/tools/testing/selftests/bpf/prog_tests/tailcalls.c

[ ... ]

> @@ -1777,6 +1928,14 @@ void test_tailcalls(void)
>  		test_tailcall_freplace();
>  	if (test__start_subtest("tailcall_bpf2bpf_freplace"))
>  		test_tailcall_bpf2bpf_freplace();
> +	if (test__start_subtest("tailcall_cgrp_storage"))
> +		test_tailcall_cgrp_storage();
> +	if (test__start_subtest("tailcall_cgrp_storage_diff_storage"))
> +		test_tailcall_cgrp_storage_diff_storage();
> +	if (test__start_subtest("tailcall_cgrp_storage_no_storage"))
> +		test_tailcall_cgrp_storage_no_storage();
> +	if (test__start_subtest("tailcall_cgrp_storage_no_storage_bridge"))
> +		test_tailcall_cgrp_storage_no_storage_bridge();
>  	if (test__start_subtest("tailcall_failure"))
>  		test_tailcall_failure();
>  	if (test__start_subtest("tailcall_sleepable"))
>  		test_tailcall_sleepable();

In the v2 review Leon Hwang asked that these new subtests be placed at the
tail of test_tailcalls():

  https://lore.kernel.org/bpf/20260603150213.68746-1-leon.hwang@xxxxxxxxx/

  "These new ones should stay at the tail of test_tailcalls()."

Here they are still registered ahead of tailcall_failure and
tailcall_sleepable rather than at the end.  Was the intent to move them
after the existing subtests?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/26923843925