Re: [PATCH v3 1/5] phy: fsl-imx8mq-usb: fix typec switch leak on probe error path

[Xu Yang]

On Wed, Jun 03, 2026 at 02:25:46PM -0400, Frank Li wrote:
> On Wed, Jun 03, 2026 at 01:37:14PM +0800, Xu Yang wrote:
> > From: Felix Gu <ustc.gu@xxxxxxxxx>
> >
> > If probe fails after imx95_usb_phy_get_tca() succeeds, the typec
> > switch leaks because the only cleanup path was in .remove, which
> > never runs on probe failure.
> >
> > Use devm_add_action_or_reset() so the switch is cleaned up on both
> > probe failure and driver removal.  The .remove callback and
> > imx95_usb_phy_put_tca() are no longer needed.
> >
> > Fixes: b58f0f86fd61 ("phy: fsl-imx8mq-usb: add tca function driver for imx95")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> > Reviewed-by: Xu Yang <xu.yang_2@xxxxxxx>
> > Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
> 
> Xu yang, if you send out patch, need your s-o-b tag

OK. Will add it in v2.

Thanks,
Xu Yang