Re: [PATCH v10 0/4] Add support for Orange Pi 5 Pro

[Dennis Gilmore]

Hi,

Just checking if anything else is needed.

Dennis

On Sun, May 10, 2026 at 9:53 PM Dennis Gilmore <dennis@xxxxxxxx> wrote:
>
> This series adds initial support for the Xunlong Orange Pi 5 Pro, based on
> the Rockchip RK3588S SoC. The board features eMMC, SD card, NVMe (PCIe),
> a Motorcomm YT6801 NIC (PCIe), WiFi/BT (BCM43456), HDMI connected to SoC
> (Second port is disabled in this patch), and a 40-pin expansion header.
>
> The series was tested against Linux 7.0
>
> Please take a look.
>
> Thank you,
>
> Dennis Gilmore
>
> Changes in v10:
> - rename rk806_single to rk806
> - link to v9: https://lore.kernel.org/linux-devicetree/20260429024737.544813-5-dennis@xxxxxxxx/
>
> Changes in v9:
> - removed support for the dp-to-HDMI bridge, will send in a second patch
>   set to enable discusion to finish on how to handle its two operating
>   modes
> - link to v8: https://lore.kernel.org/linux-devicetree/20260425031011.2529364-1-dennis@xxxxxxxx/
>
> Changes in v8:
> - Bridge node: renamed label from lt8711uxd to hdmi-bridge
> - Bridge node: added vdd-supply = <&vcc3v3_dp>. The vcc3v3_dp regulator
>   gates power to the LT8711UXD. regulator-always-on is kept because
>   drm_simple_bridge only enables vdd-supply with HPD which does not
>   happen without power on
> - GPIO output pinctrl groups (bt_wake_gpio, dp_bridge_en, ethernet_en,
>   vcc5v0_otg_en, wifi_enable_h) changed from pcfg_pull_none to
>   pcfg_pull_down to match the RK3588S power-on-reset default state
> - pcie2x1l1 (NVMe): switched from GPIO-mode reset to hardware sideband pins
>   using pinctrl-0 = <&pcie30x1m1_1_perstn>, <&pcie30x1m1_1_clkreqn>,
>   <&pcie30x1m1_1_waken>. Note: despite the "pcie30" prefix in the DTSI
>   group names, the SoC pin-mux table confirms these alt-function 4 pads
>   physically route to pcie2x1l1's native PERST#/CLKREQ#/WAKE# inputs.
>   reset-gpios is retained alongside the pinctrl entry for U-Boot
>   compatibility (pcie_dw_rockchip in U-Boot requires reset-gpios).
> - pcie2x1l2 (NIC): added &pcie20x1m0_clkreqn and &pcie20x1m0_waken to
>   pinctrl-0
> - Renamed pinctrl group vcc3v3_phy1_en to ethernet_en to match the
>   schematic signal name (Ethernet_EN)
> - link to v7: https://lore.kernel.org/linux-devicetree/20260414214104.1363987-1-dennis@xxxxxxxx/
>
> Changes in v7:
> - Fix up whitespace issues identified by checkpatch.pl --strict in
>   rk3588s-orangepi-5-5b.dtsi
> - checkpatch gave a warning for WARNING: phy-mode "rgmii-rxid" without
>   comment, as this was moved over I left it untouched
> - Added lontium,lt8711uxd to the compatible enum in the simple-bridge
>   binding
> - Added lontium,lt8711uxd match entry with DRM_MODE_CONNECTOR_HDMIA to
>   the simple-bridge driver
> - New patch to rename the regulator labels for the es8388 supplies to
>   match the schematics and they all use vcca_*
> - Fixed ES8388 PVDD-supply — vcca_3v3_s0 → vcca_1v8_s0, 5 Pro is
>   different to 5 and 5b.
> - analog-sound: use CPU-as-clock-master on the Pro. The ES8388 is wired to
>   i2s2_2ch (the only I2S block physically routed to the codec pins on this
>   board), which uses the legacy rockchip_i2s driver. That driver's
>   slave-mode trigger path hangs for 200 µs polling I2S_CLR and bails with
>   -ETIMEDOUT ("lrclk update failed"). The TDM-capable i2s0/i2s1/i2s5
>   blocks served by rockchip_i2s_tdm don't have this issue, which is why
>   other mainline ES8388 boards get away with bitclock-master = masterdai.
>   Drop bitclock-master/frame-master and the masterdai label to let the I2S
>   block generate BCLK/LRCK itself
> - Removed regulator-always-on/regulator-boot-on from vcc3v3_dp
> - Added pinctrl entries for all GPIO pins (dp_bridge_en, vcc3v3_phy1_en,
>   wifi_enable_h, pcie2x1l1_rst, pcie2x1l2_rst)
> - DP bridge rework — replaced dp-connector node with proper chain:
>     - lt8711uxd bridge node (compatible lontium,lt8711uxd, with port@0/port@1
>       endpoints). Bridge power is gated by the vcc3v3_dp regulator, whose
>       enable GPIO (GPIO3_PC2) is driven via the dp_bridge_en pinctrl group;
>       no enable-gpios/vdd-supply on the bridge node itself.
>     - hdmi1-con connector node (compatible hdmi-connector, type a)
>     - dp0_out endpoint now points to bridge input instead of old connector
> - remove accidentally included unnecessary changes
> - link to v6: https://lore.kernel.org/linux-devicetree/20260411024743.195385-1-dennis@xxxxxxxx/
>
> Changes in v6:
> - Move the shared configs for the Orange Pi 5 and Orange Pi 5b from each
>   devices dts to a shared rk3588s-orangepi-5-5b.dtsi to avoid duplication
> - Remove empty ports subnodeis from typea_con
> - Move i2s2m1_mclk pinctrl from &i2s2 to the es8388 codec node
> - Add dp-con, dp0_out, dp0_in, and vp1 nodes, plus the vcc3v3_dp regulator
>   in order to get the second HDMI port working via its transparent
>   LT8711UXD DP to HDMI bridge
> - link to v5: https://lore.kernel.org/linux-devicetree/20260401010707.2584962-1-dennis@xxxxxxxx/
>
> Changes in v5:
> - define a connector node for Type-A port, and list the regulator as its VBUS supply explicitly.
> - Requires https://lore.kernel.org/all/20260217-typea-vbus-v1-1-657b4e55a4c2@xxxxxxxxxxx/
> - link to v4: https://lore.kernel.org/linux-devicetree/20260310031002.3921234-1-dennis@xxxxxxxx/
>
> Changes in v4:
> - rename vcc3v3_pcie20 copied from rk3588s-orangepi-5.dts to vcc3v3_phy1 to match the schematic
> - use vcc_3v3_s3 as the supply not vcc5v0_sys for PCIe
> - remove the definition for vcc3v3_pcie_m2 as it does not really exist
>   as a regulator
> - link to v3: https://lore.kernel.org/linux-devicetree/20260306024634.239614-1-dennis@xxxxxxxx/
>
> Changes in v3:
> - moved leds from gpio-leds to pwm-leds
> - remove disable-wp from sdio
> - rename vcc3v3_pcie_eth regulator to vcc3v3_pcie_m2 to reflect the
>   purpose
> - actually clean up the delete lines and comments missed in v2
> - link to v2: https://lore.kernel.org/linux-devicetree/20260304025521.210377-1-dennis@xxxxxxxx/
>
> Changes in v2:
> - moved items not shared by orangepi 5/5b/5 Pro from dtsi to 5 and 5b
>   dts files
> - removed all the comments and deleted properties from 5 Pro dts
> - link to v1: https://lore.kernel.org/linux-devicetree/20260228205418.2944620-1-dennis@xxxxxxxx/
>
> Dennis Gilmore (4):
>   dt-bindings: arm: rockchip: Add Orange Pi 5 Pro
>   arm64: dts: rockchip: rk3588s-orangepi-5: rename PLDO regulator labels
>     to match schematic
>   arm64: dts: rockchip: refactor items from Orange Pi 5/b to prep for
>     Pro
>   arm64: dts: rockchip: Add Orange Pi 5 Pro board support
>
>  .../devicetree/bindings/arm/rockchip.yaml     |   1 +
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../dts/rockchip/rk3588s-orangepi-5-5b.dtsi   | 256 +++++++++++++
>  .../dts/rockchip/rk3588s-orangepi-5-pro.dts   | 358 ++++++++++++++++++
>  .../boot/dts/rockchip/rk3588s-orangepi-5.dts  |   6 +-
>  .../boot/dts/rockchip/rk3588s-orangepi-5.dtsi | 263 +------------
>  .../boot/dts/rockchip/rk3588s-orangepi-5b.dts |   2 +-
>  7 files changed, 637 insertions(+), 250 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-pro.dts
>
> --
> 2.54.0
>