Re: [PATCH 05/12] iio: dac: ad5686: add support for missing power supplies

[Andy Shevchenko]

On Wed, Jun 03, 2026 at 01:17:25PM +0100, Rodrigo Alencar wrote:
> On 26/06/02 10:02PM, Andy Shevchenko wrote:
> > On Tue, Jun 02, 2026 at 05:33:52PM +0100, Rodrigo Alencar via B4 Relay wrote:

...

> > > +	ret = devm_regulator_get_enable_read_voltage(dev, "vref");
> > > +	if (ret == -ENODEV) /* vcc-supply is deprecated, but supported still */
> > > +		ret = devm_regulator_get_enable_read_voltage(dev, "vcc");
> > 
> > >  	if (ret < 0 && ret != -ENODEV)
> > 
> > It can be deduplicated now with
> > 
> > 	else if (ret < 0)
> 
> Not really, because ret is overwritten with
> 
> 	ret = devm_regulator_get_enable_read_voltage(dev, "vcc")
> 
> so the check for if (ret < 0 && ret != -ENODEV) is intentional

Indeed, thanks for pointing this out.

> > > -		return ret;
> > > +		return dev_err_probe(dev, ret, "failed to read vref voltage\n");

-- 
With Best Regards,
Andy Shevchenko