Re: [PATCH v2] iio: pressure: rohm-bm1390: notify trigger on all error paths

[Matti Vaittinen]

On 01/06/2026 21:36, Andy Shevchenko wrote:
> On Fri, May 29, 2026 at 11:21:40AM +0300, Matti Vaittinen wrote:
> > On 22/05/2026 15:38, Matti Vaittinen wrote:
> > > On 20/05/2026 14:08, Jonathan Cameron wrote:
> > > > On Tue, 19 May 2026 08:48:13 +0300
> > > > Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
>
> ...
>
> > +#ifdef TEST_FORCE_IRQ_NONE
> > +       /* HACK, return IRQ_NONE and see if IRQ gets disabled */
> > +       if (!(first2 % 1000))
> > +               pr_info("Hack, return IRQ_NONE (%lu th)\n", first2);
>
> Hint: pr_info_ratelimited() seems better?

Thanks Andy. Yes, I suppose so. It's just that I _really_ rarely need 
ratelimit prints. Hence I don't remember exact form of these print APIs 
without checking for them. And it's easier to add a static counter (as a 
unsafe debug hack) than search for the function signatures ;)

> > +       first2++;
> > +
> > +       return IRQ_NONE;
> > +#else
> >          return IRQ_HANDLED;
> > +#endif


Yours,
	-- Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~