Re: [PATCH 1/2] dt-bindings: spi: Add for Nuvoton MA35D1 SoC QSPI Controller

[Chi-Wen Weng]

Hi Conor,

Thanks for the review.

> Missing commit message for one, but why can't your Nuvoton mail be used
> here?

I apologize for the missing commit message; I will add a proper 
description in v2.

Regarding the email address, my Nuvoton mail adds a corporate 
confidentiality disclaimer to outgoing
external mail, so I use my personal address for sending kernel patches.

> Sashiko had two comments about resets and num-cs that looked valid.

Noted. I will add the `num-cs` and `resets` properties in v2.

> Drop this flash node, it serves no purpose here.

Understood, I will remove the flash child node from the example in v2.

Thanks,
Chi-Wen Weng

Conor Dooley 於 2026/6/3 下午 11:24 寫道:
> On Wed, Jun 03, 2026 at 12:35:50PM +0800, Chi-Wen Weng wrote:
> > Signed-off-by: Chi-Wen Weng <cwweng.linux@xxxxxxxxx>
> Missing commit message for one, but why can't your Nuvoton mail be used
> here?
>
> Sashiko had two comments about resets and num-cs that looked valid.
>
> > ---
> >   .../bindings/spi/nuvoton,ma35d1-qspi.yaml     | 61 +++++++++++++++++++
> >   1 file changed, 61 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml b/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml
> > new file mode 100644
> > index 000000000000..f7b9cb52d8e5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spi/nuvoton,ma35d1-qspi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nuvoton MA35D1 Quad SPI Controller
> > +
> > +maintainers:
> > +  - Chi-Wen Weng <cwweng@xxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: spi-controller.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: nuvoton,ma35d1-qspi
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        spi@40680000 {
> > +            compatible = "nuvoton,ma35d1-qspi";
> > +            reg = <0x0 0x40680000 0x0 0x100>;
> > +            interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
> > +            clocks = <&clk QSPI0_GATE>;
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            flash@0 {
> Drop this flash node, it serves no purpose here.
>
> pw-bot: changes-requested
>
> Thanks,
> Conor.
>
> > +                compatible = "jedec,spi-nor";
> > +                spi-max-frequency = <30000000>;
> > +                reg = <0>;
> > +                spi-rx-bus-width = <4>;
> > +                spi-tx-bus-width = <1>;
> > +            };
> > +        };
> > +    };
> > +
> > --
> > 2.25.1