Re: [PATCH v3 4/8] iio: tcs3472: use ! instead of explicit NULL check
From: Joshua Crofts
Date: Thu Jun 04 2026 - 04:49:26 EST
On Thu, 4 Jun 2026 at 10:31, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Fri, May 22, 2026 at 02:34:15PM +0200, Aldo Conte wrote:
> > Replace 'if (indio_dev == NULL)' with 'if (!indio_dev)' in
> > tcs3472_probe() to follow the preferred kernel style.
>
> > Suggested-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
>
> Joshua, even if it's not written in the documentation (or unclear) the idea is
> that whoever formally suggested the change has to acknowledge it (Acked-by is
> enough, but full review is superior, of course).
I see, thanks for the heads up. Not sure if Jonathan will add my tag
at this point,
nevertheless
Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
--
Kind regards
CJD